On Sat, 8 Jul 2023 23:32:58 GMT, Michael Strauß <[email protected]> wrote:
>> modules/javafx.graphics/src/test/java/test/com/sun/javafx/util/DataURITest.java
>> line 183:
>>
>>> 181: // We use URLEncoder here to escape the emoji character using
>>> percent-encoding.
>>> 182: // When DataURI parses its payload, it automatically converts
>>> percent-encoded characters back to octets.
>>> 183: String input = URLEncoder.encode("🙂", StandardCharsets.UTF_8);
>>
>> would it make sense to try several different strings that include +, \n, \t,
>> data:, charset:, %, empty string, &, _, %zz?
>
> Most of these cases should already be covered by existing tests
> (`testMissingDataSeparatorIsInvalid`,
> `testParametersListWithoutKeyValuePairsIsInvalid`,
> `testLeadingOrTrailingWhitespaceIsAcceptable`).
minor(?): Is it common practice for the FX code base to include non-ASCII
characters? If not, perhaps encode this instead of using the smiley directly
(or use an ASCII character that requires % escaping, like `%`).
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1165#discussion_r1375182459
