On Wed, 1 Nov 2023 14:56:23 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review changes
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/application/preferences/PlatformPreferences.java
> line 122:
>
>> 120:
>> 121: @Override
>> 122: public Optional<Integer> getInteger(String key) {
>
> Q: is it possible to encounter an unsigned 64 bit value?
> Should we allow for BigInteger?
IMHO this can be added when there's a use case.
Also, an int can support all values of an unsigned variant, you just need to be
careful when interpreting it (ie. do `long unsigned = i & 0xffffffffL` first).
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1378940028
