On Wed, 1 Nov 2023 15:16:54 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> A recent change to Skara in processing of the .jcheck/conf file > ([SKARA-2080](https://bugs.openjdk.org/browse/SKARA-2080)) introduced a bug > in processing the `[checks "reviewers"]` section that causes the `/reviewers` > command to be ignored in some cases. This is tracked by > [SKARA-2088](https://bugs.openjdk.org/browse/SKARA-2088). The reason we > tripped over this bug is that the `.jcheck/conf` file used by jfx (including > various update release repos) uses an unrecognized key, "minimum", instead of > the expected "reviewers" key to indicate the minimum number of reviewers. We > should fix this to be consistent with what Skara expects given the intent of > our `[checks "reviewers"]` section. @edvbld Can you review this? @andy-goryachev-oracle Can you be the "R"eviewer (once Erik D reviews it)? NOTE: This matches the [equivalent line](https://github.com/openjdk/jdk/blob/master/.jcheck/conf#L25) in the jdk repo's `.jcheck/conf'` file. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1275#issuecomment-1789143456 PR Comment: https://git.openjdk.org/jfx/pull/1275#issuecomment-1789145562
