On Fri, 10 Nov 2023 21:23:54 GMT, Michael Strauß <mstra...@openjdk.org> wrote:

>> Please read [this 
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) 
>> for an introduction to the Platform Preferences API, and how it interacts 
>> with the proposed style theme and stage appearance features.
>
> Michael Strauß has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Rename Appearance to ColorScheme

Joe commented on the CSR that we might have `Appearance` implement an interface 
and use this interface in the API to be more flexible. While I don't agree with 
this (the dark-on-light flag doesn't need to be more complex than it is), I 
acknowledge that naming it "appearance" might be a bit too much.

I decided to rename the `Appearance` enum to `ColorScheme`, which is the term 
the CSS specification uses for the same concept. This frees up the term 
`Appearance` to be used for a future enhancement that may encompass more 
aspects than just the color scheme.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1014#issuecomment-1806457037

Reply via email to