On Mon, 20 Nov 2023 19:12:25 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > Support polymorphic values I feel that the gist mentioned in the description (https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548 ) has value for the application developers (after updating it with the current detail), but once this PR is integrated it will be hard to find (and located in a private repository). There is a bit of overlap between the gist and the CSR, but CSR has a much narrower focus. It is my personal opinion that the gist should be moved to doc-files/jeps or doc-files/application-notes, in other words, in the documents in the repo. If I recall correctly, @kevinrushforth is against this idea, saying that documentation belongs in a wiki somewhere, but I disagree. Markdown is a good format that provides a reasonably nice visual rendering and is compatible with the code review tooling, so it can be reviewed as a part of the code review. I don't like wikis in general because they become obsolete quickly, are hard to maintain, and are not linked with the code. What do you think? ------------- PR Comment: https://git.openjdk.org/jfx/pull/1014#issuecomment-1819666158
