On Tue, 21 Nov 2023 20:19:04 GMT, John Neffenger <[email protected]> wrote:
> Backport 16169240667876633895b27464eb90033abb6166
>
> Please review this backport of openjdk/jfx#1253 to JavaFX 21. Please give me
> a day or two to test it again before starting your review.
I ran the builds and unit tests on Linux, macOS, and Windows. All builds and
tests were successful. The run-time and build-time versions are as expected:
$ grep 'static final String' \
linux/modules/javafx.base/build/gensrc/java/com/sun/javafx/runtime/VersionInfo.java
private static final String BUILD_TIMESTAMP = "2023-11-21-201527";
private static final String HUDSON_JOB_NAME = "not_hudson";
private static final String HUDSON_BUILD_NUMBER = "0000";
private static final String RELEASE_SUFFIX = "-internal";
private static final String VERSION = "21.0.2-internal";
private static final String RUNTIME_VERSION =
"21.0.2-internal+0-2023-11-21-201527";
$ cat linux/build/sdk/lib/javafx.properties
javafx.version=21.0.2-internal
javafx.runtime.version=21.0.2-internal+0-2023-11-21-201527
javafx.runtime.build=0
The only thing that didn't get copied over with the original commit is the
updated copyright statement in the `VersionInfo.java` class:
$ for f in $(git diff master --name-only); do echo "$f"; grep Copyright "$f";
done
UPDATING-VERSION.md
build.gradle
* Copyright (c) 2013, 2023, Oracle and/or its affiliates. All rights reserved.
modules/javafx.base/src/main/version-info/VersionInfo.java
* Copyright (c) 2011, 2022, Oracle and/or its affiliates. All rights reserved.
modules/javafx.base/src/test/java/test/com/sun/javafx/runtime/VersionInfoTest.java
* Copyright (c) 2011, 2023, Oracle and/or its affiliates. All rights reserved.
In general, do we try to keep that copyright statement updated when backporting
a fix?
By the way, could a lawyer at Oracle take a look into whether we could stop
updating the copyright years or even drop the years altogether? Apparently, it
all [started with *curl*][1], but now [everyone's doing it][2] (Amazon,
Microsoft, Facebook, Google, Netflix) — or rather, **not** doing it. 😄 The most
authoritative post about the subject might be [this one from the Linux
Foundation][3].
[1]: https://daniel.haxx.se/blog/2023/01/08/copyright-without-years/
[2]: https://hynek.me/til/copyright-years/
[3]:
https://www.linuxfoundation.org/blog/blog/copyright-notices-in-open-source-software-projects
-------------
PR Comment: https://git.openjdk.org/jfx21u/pull/32#issuecomment-1823070821
