On Sat, 2 Dec 2023 01:43:52 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > check for pending exceptions in Windows PlatformSupport modules/javafx.graphics/src/main/native-glass/mac/GlassMacros.h line 165: > 163: > 164: // assert there is no outstanding java exception pending, return > otherwise > 165: #define GLASS_CHECK_EXCEPTIONALLY_RETURN(ENV) > \ Minor: `GLASS_CHECK_EXCEPTION_RETURN` might be a more consistent name (but please leave it as is if you prefer). modules/javafx.graphics/src/main/native-glass/win/PlatformSupport.cpp line 235: > 233: jobject prefValue = value ? > 234: env->GetStaticObjectField(javaClasses.Boolean, > javaIDs.Boolean.trueID) : > 235: env->GetStaticObjectField(javaClasses.Boolean, > javaIDs.Boolean.falseID); Minor: do you think it is worth caching `Boolean.TRUE` and `Boolean.FALSE` in static `const` variables? It likely won't matter much. modules/javafx.graphics/src/test/java/test/com/sun/javafx/application/preferences/ChangedValueTest.java line 2: > 1: /* > 2: * Copyright (c) 2023 Oracle and/or its affiliates. All rights reserved. Missing comma after `2023` modules/javafx.graphics/src/test/java/test/com/sun/javafx/application/preferences/PlatformPreferencesTest.java line 2: > 1: /* > 2: * Copyright (c) 2023 Oracle and/or its affiliates. All rights reserved. Missing comma after `2023` ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1414563364 PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1414568701 PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1414583048 PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1414583300
