On Tue, 5 Dec 2023 23:26:11 GMT, Kevin Rushforth <[email protected]> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> check return value of JNI functions
>
> modules/javafx.graphics/src/main/native-glass/win/RoActivationSupport.cpp
> line 213:
>
>> 211: RoException& RoException::operator=(RoException source)
>> 212: {
>> 213: std::swap(*this, source);
>
> Did you mean to do the swap here?
Yes. This is the copy-and-swap idiom, where the copy is made by using a
pass-by-value parameter.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1416497565
