On Thu, 7 Dec 2023 17:21:05 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features. > > Michael Strauß has updated the pull request incrementally with three > additional commits since the last revision: > > - removed unused import > - javadoc > - query resource bundles for high-contrast schemes only on Windows Manual test on macOS and Windows looks good now. I've left one comment modules/javafx.graphics/src/main/java/com/sun/javafx/application/WindowsHighContrastScheme.java line 43: > 41: * The high contrast feature may not be available on all platforms. > 42: */ > 43: enum WindowsHighContrastScheme { I'd rather keep the old name: `HighContrastScheme`: It is in a non-platform specific package, and it applies to all platforms (even only with `NONE`). You could add a comment about `HIGH_CONTRAST_*` enum constants being only available on Windows. ------------- PR Review: https://git.openjdk.org/jfx/pull/1014#pullrequestreview-1770790578 PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1419429539
