On Mon, 11 Dec 2023 18:36:35 GMT, Jose Pereda <jper...@openjdk.org> wrote:

> This PR prevents changes in direction when dragging a tab header over a 
> TabPane control, if delta value is zero, which can happen with slow drag 
> events, in order to prevent starting and stopping too frequently the 
> animation of the target tab header in opposite directions.

modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java
 line 2162:

> 2160:         }
> 2161:         // Stop dropHeaderAnim if direction of drag is changed
> 2162:         if (dragDirection != 0 && prevDragDirection != dragDirection) {

Did you mean `dragDelta != 0`?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1304#discussion_r1422992199

Reply via email to