On Fri, 5 Jan 2024 23:59:31 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> As noted in the JBS bug, this is a follow-on to > [JDK-8196011](https://bugs.openjdk.org/browse/JDK-8196011) that I discovered > while testing the fix for > [JDK-8221261](https://bugs.openjdk.org/browse/JDK-8221261) (a deadlock in the > IME code when using WebView in a JFXPanel on macOS). > > I have tested this in connection with with the proposed fix for JDK-8221261, > although it is a valid fix regardless. > > This expands the fix done in > [JDK-8221261](https://bugs.openjdk.org/browse/JDK-8221261) to call all of the > WebKit methods on the right thread. Additionally, we sometimes see spurious > exceptions where the committed text is coming back as null, so I changed the > log level to "fine" rather than "severe" for those exceptions. I'll file a > follow-up bug to see if any of these are real problems or not. NOTE to reviewers: If you want to test this, you will also need the fix for [JDK-8221261](https://bugs.openjdk.org/browse/JDK-8221261), which is under review in PR #1327 to avoid the deadlock. I have created a test branch that has both fixes: https://github.com/kevinrushforth/jfx/tree/test-8221261-8322703 You can either fetch that branch or fetch both PR branches and build. It is not necessary to build the native WebKit if you have an up-to-date library in your cache. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1321#issuecomment-1885428778
