On Thu, 18 Jan 2024 07:30:05 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> modules/javafx.swing/src/main/java/javafx/embed/swing/InputMethodSupport.java >> line 106: >> >>> 104: }); >>> 105: } >>> 106: if (stringValue == null) stringValue = ""; >> >> Not sure of FX coding guidelines but in JDK, even for a single statement, we >> need to put in braces > > I guess this should add > [JDK-8090267](https://bugs.openjdk.org/browse/JDK-8090267) through "/issue > add" command Regarding FX coding style, the one place where braces are not needed is when everything is all on one line. Regarding [JDK-8090267](https://bugs.openjdk.org/browse/JDK-8090267), should the call to `getInputMethodRequests` added to [JFXPanel line 1028](https://github.com/openjdk/jfx/pull/1169/files#diff-e6f5782dba36f256cceb649ce526ed1f7a8f6704d3a32bd8bd17cef42621d99cR1028) by PR #1169 be added to this PR as well? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1337#discussion_r1457453171
