On Tue, 23 Jan 2024 17:24:05 GMT, Martin Fox <m...@openjdk.org> wrote:
>> On Windows we need to ensure InputMethodRequests coming from JFXPanel are >> processed on the JavaFX application thread instead of the AWT EventQueue >> thread. This PR adds the runAndWait() calls to do that. >> >> This would be difficult to test on Windows without a fix for >> [JDK-8090267](https://bugs.openjdk.org/browse/JDK-8090267) so I've included >> the fix first proposed by @prsadhuk in PR #1169. If a developer uses the >> sample code provided in the JavaDoc to create and show a JFXPanel there's a >> good chance the JFXPanel will get focus before the scene has been set. To >> ensure AWT always treats the JFXPanel as an active IME client we return a >> stub version of the InputMethodRequests object if there's no scene. AWT will >> continue to ask for the InputMethodRequests and once the scene has been set >> the panel will return a non-stub version. > > Martin Fox has updated the pull request incrementally with one additional > commit since the last revision: > > Switch to using AtomicReference/AtomicInteger Looks good. I tested it on both macOS (to confirm no deadlock) and on Windows (to test the fix). All good. ------------- Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1337#pullrequestreview-1839637887
