On Wed, 10 Jan 2024 02:36:32 GMT, Philippe Altherr <d...@openjdk.org> wrote:

> 8324797: Code example in JavaDoc of ObservableValue#when doesn't compile

@paltherr Good  catch. This needs a JBS bug ID. Maybe @hjohn would help sponsor 
this for you (in which case he could create the doc bug)?

See the [CONTRIBUTING 
guidelines](https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md) for 
information about how to file a bug (along with other information about pull 
requests). As this is a simple doc bug, you won't need a very detailed 
description in the bug report.

The existing example code doesn't compile, since there is no 
`ObservableValue::setValue` method.

> I noticed that here and here in the same file you have the same issue and 
> avoid it by using a var, which looks cleaner. My fix should probably do the 
> same.

Either is fine with me. I'll let @hjohn decide, since he wrote all three 
examples.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1325#issuecomment-1912545088
PR Comment: https://git.openjdk.org/jfx/pull/1325#issuecomment-1912667688
PR Comment: https://git.openjdk.org/jfx/pull/1325#issuecomment-1913183878
PR Comment: https://git.openjdk.org/jfx/pull/1325#issuecomment-1913186620

Reply via email to