On Fri, 9 Feb 2024 13:09:23 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review feedback > > modules/javafx.graphics/src/main/java/com/sun/prism/sw/SWGraphics.java line > 664: > >> 662: getRenderTarget().isOpaque() && >> 663: (this.paint.getType() == Paint.Type.COLOR) && >> 664: ((Color)this.paint).getAlpha() == 1.0f && > > Could avoid the cast here if you want: > > Suggestion: > > this.paint instanceof Color c && > c.getAlpha() == 1.0f && I had thought of it earlier, but didn't do it at the time. I made this change along with the suggested test changes. Thanks for the suggestions. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1361#discussion_r1484397314
