On Fri, 9 Feb 2024 19:17:00 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> I guess the reason for explicit hiding() of the stages passed to it was done >> for the sake of headless tests? > > It's not really a headless vs headful distinction (the system tests are all > headful). It's just that some tests have a global (static) Stage that should > be hidden at shutdown time. Others, like the test in this PR, create, hide, > and show a Stage in each test instance. Both are valid use cases. here it's under @AfterAll, not after each test. But still, what's the point of hiding the stage(s) if we follow it with Platform.exit() ? Then we should get rid of the stage(s) argument and simply hide all the current stages, regardless. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1361#discussion_r1484715440
