On Thu, 29 Feb 2024 00:07:37 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> This change brings the number of javadoc warnings back to 91 (to be fixed in >> [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996)) >> >> - adds missing information in `@param` tags >> - adds `@SuppressWarnings("doclint:missing")` to `Skinnable` to silence the >> warning due to [JDK-8325071](https://bugs.openjdk.org/browse/JDK-8325071) >> - fixed an empty `<p>` in `Subscription` >> - cleaned up unnecessary `@throws` in Filtered/SortedList >> >> Q: Does this PR need a CSR? > > modules/javafx.base/src/main/java/javafx/collections/transformation/FilteredList.java > line 164: > >> 162: * @param index index of the element to return >> 163: * @return the element at the specified position in this list >> 164: * @throws IndexOutOfBoundsException {@inheritDoc} > > Was this generating a warning? Does the superclass specify `@throws`? yes, the superclass specified @throws. this line generated FilteredList.java:164: warning: overridden methods do not document exception type java.lang.IndexOutOfBoundsException (module java.base package java.lang class IndexOutOfBoundsException) * @throws IndexOutOfBoundsException {@inheritDoc} ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1384#discussion_r1508331500
