On Sun, 24 Mar 2024 15:11:16 GMT, drmarmac <d...@openjdk.org> wrote:

> This PR should fix the issue and cover all relevant cases with new tests.
> 
> Note: This involves a small behavior change, as can be seen in 
> dblSpinner_testWrapAround_decrement_twoSteps() in SpinnerTest.java:749. With 
> this change the wraparound behavior is similar to that of the IntegerSpinner.

afair, we already had extensive discussions in 
https://github.com/openjdk/jfx/pull/174 (and the related bug and the mailing 
list - too lazy to read up on all that) agreeing that modulo math (correctly 
done!) fits common client programmers' expectations most  - doesn't matter the 
step size.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1431#issuecomment-2022504622

Reply via email to