On Mon, 8 Apr 2024 22:25:53 GMT, Andy Goryachev <[email protected]> wrote:
>> tests/manual/text/EmojiTest.java line 34:
>>
>>> 32: import com.oracle.util.testing.ManualTestWindow;
>>> 33:
>>> 34: public class EmojiTest {
>>
>> Our existing manual tests all extend `Application`. Is there a reason this
>> has to change? Absent a compelling reason, I'd prefer to not require test
>> apps to stop extending Application in order to use this utility.
>
> Everything, including creating an instance of Application, is taken care of
> by the `ManualTestWindow`. This simplifies the test code greatly.
>
> What is the reason that the test must extend `Application`?
For example if test needs to access `getParameters()` or `getHostServices ()`
from `Application` how it can be done? I think it might be better to extend
`ManualTestWindow` from `Application` and require test itself to extend
`ManualTestWindow`. In this case tests will extend `Application`.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1413#discussion_r1556506989
