On Wed, 10 Apr 2024 11:47:28 GMT, drmarmac <d...@openjdk.org> wrote: >> This PR should fix the issue and cover all relevant cases with new tests. >> >> Note: This involves a small behavior change, as can be seen in >> dblSpinner_testWrapAround_decrement_twoSteps() in SpinnerTest.java:749. With >> this change the wraparound behavior is similar to that of the IntegerSpinner. > > drmarmac has updated the pull request incrementally with one additional > commit since the last revision: > > Use direction-dependent modulo arithmetic in DoubleSpinnerValueFactory > wrap-around logic
LGTM. This PR fixes both the issues mentioned. Like @andy-goryachev-oracle mentioned, better to describe new behaviour in JDK-8242553 description. ------------- Marked as reviewed by kpk (Committer). PR Review: https://git.openjdk.org/jfx/pull/1431#pullrequestreview-2003877662
