On Mon, 6 May 2024 16:26:42 GMT, Andy Goryachev <[email protected]> wrote:
>> This PR updates the javadoc for the SpinnerFactory wrap-around behavior
>> introduced in #1431.
>
> modules/javafx.controls/src/main/java/javafx/scene/control/SpinnerValueFactory.java
> line 417:
>
>> 415: * integer values.
>> 416: * <p>
>> 417: * If {@link #wrapAround} is {@code true}, the {@code
>> IntegerSpinnerValueFactory} will step from
>
> The link for wrapAround does not resolve in Eclipse.
> I'd suggest to change it to
>
> * If {@link SpinnerValueFactory#wrapAround wrapAround}
>
>
> Same comment applies to the min and max in line 420.
I don't think this will help. This is the same issue I mentioned in PR #1389 --
you need to link to the property _method_, so I think changing to the following
will do it:
* If {@link #wrapAroundProperty wrapAround}
(it shouldn't be necessary to qualify it with the enclosing class, but it
wouldn't hurt to do so)
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1450#discussion_r1591345778
