On Tue, 28 May 2024 17:55:24 GMT, Andy Goryachev <[email protected]> wrote:
>> This PR fixes the incorrect computation of the `CornerRadii.uniform` flag
>> for the 16-argument constructor.
>>
>> I've also added tests for all other constructors.
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/CornerRadiiTest.java
> line 65:
>
>> 63:
>> 64: @Nested
>> 65: class IsUniformTests {
>
> just curious - what was the rationale for `@Nested` here, as the number of
> the test cases is fairly small.
I will add some more tests with
[JDK-8332895](https://bugs.openjdk.org/browse/JDK-8332895) (adding
interpolation support), and the `@Nested` nicely groups all tests for a given
functionality.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1465#discussion_r1617700166
