On Wed, 13 Dec 2023 09:20:12 GMT, Jose Pereda <jper...@openjdk.org> wrote:
>> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> process reviewers comments > > About adding an automated test, the leak that PR tries to fix happens in > `com.sun.javafx.tk.quantum.GlassSystemMenu`, which is package private, and > adding new tests to check `javafx.scene.control.Menu`, or related public > classes, won't catch that leak, will it? > > Unless we open it (and all the related classes/methods in > `com.sun.glass.ui.*`), I don't think it can be done? @jperedadnr @hjohn can you review this? @kevinrushforth feel free to add other reviewers. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1283#issuecomment-2163597794
