On Sun, 7 Jul 2024 00:34:01 GMT, Nir Lisker <nlis...@openjdk.org> wrote:

> Do you have any remarks?

I personally don't launch build tools from the IDE (neither Gradle, nor Maven) 
but only use such tools to import projects; after the import I expect the IDE 
to be able to build and run tests without intervention of any build tool.  I 
will use the build tooling (usually on the command line) only as a last resort 
if I can't get it to work that way (which is sometimes the case for a 
complicated project like JavaFX, especially when I need to run a non-headless 
test).  Importing and working this way works for almost any project, but never 
has worked for me with JavaFX (which was a big barrier for me when I first 
tried contributing to FX -- I even tried switching IDE's, but it wasn't much 
better there either).

What annoys me the most with the FX project is the inability to run certain 
tests directly from the IDE by right clicking and selecting `Run as... JUnit 
test`.  I work around this by running the test once, then changing its 
configuration and adding a standard incantation to its command line 
(`-Djavafx.toolkit`, `-Djava.library.path`, some `--add-modules`) -- I can live 
with that, although it is less than ideal (right clicking and running a test 
would be nice to have working out of the box for JavaFX).

I doubt however this change will make this any better or worse :)

So, I'm fine with either solution here.  As I don't use Gradle integration, I'd 
lean slightly to just removing it, or alternatively, fixing the problems in the 
gradle build so Buildship recognizes it properly.  Since I suspect the latter 
is not an easy task, removing the Gradle nature seems like a good alternative.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1491#issuecomment-2213464459

Reply via email to