On Mon, 6 May 2024 14:14:05 GMT, eduardsdv <d...@openjdk.org> wrote: > This is an alternative solution to the PR: > https://github.com/openjdk/jfx/pull/1310. > > This solution is based on the invariant that if a node is marked as dirty, > all ancestors must also be marked as dirty and that if an ancestor is marked > as clean, all descendants must also be marked as clean. > Therefore I removed the ``clearDirtyTree()`` method and put its content to > the ``clearDirty()`` method. > > Furthermore, since dirty flag is only used when rendering by ``ViewPainter``, > it should also be deleted by ``ViewPainter`` only. > This guarantees: > 1. that all dirty flags are removed after rendering, and > 2. that no dirty flags are removed when a node is rendered, e.g. by creating > a snapshot or printing. > Therefore I removed all calls of the methods ``clearDirty()`` and > ``clearDirtyTree()`` from all other classes except the ``ViewerPainter``. > > The new version of the ``clearDirty()`` method together with calling it from > the ``ViewerPainter`` needs to visit far fewer nodes compared to the version > prior this PR. > > The supplied test checks that the nodes are updated even if they are > partially covered, which led to the error in the version before the PR. The > test can be started with: > ``gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests > NGNodeDirtyFlagTest``
This pull request has now been integrated. Changeset: 9723a9c4 Author: Eduard Sedov <eduard.se...@zeiss.com> Committer: Lukasz Kostyra <lkost...@openjdk.org> URL: https://git.openjdk.org/jfx/commit/9723a9c4ce3a4490df962b83da0df71b1e5145f1 Stats: 243 lines in 11 files changed: 172 ins; 47 del; 24 mod 8322619: Parts of SG no longer update during rendering - overlapping - culling - dirty Reviewed-by: arapte, lkostyra ------------- PR: https://git.openjdk.org/jfx/pull/1451
