On Tue, 9 Jul 2024 13:03:18 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
> I think this is ready for a closer inspection again I'll put it on my review queue for after Thursday's fork. > in a strict sense there are API additions in this PR, but because of how > `sealed` works, they're not accessible except to permitted sub types (and > none of those permitted types are public API). Right, the API additions are the package-scope constructor and the `readBinary` method, although as you say, they are only accessible to internal JavaFX classes. Since `Selector` will be a sealed class with all permitted classes being internal, no package-scope methods can be accessed by an application. The main API change is the removal of the terminally-deprecated `SimpleSelector` and `CompoundSelector` classes. With that in mind, a better title for this bug would be: "Remove SimpleSelector and CompoundSelector classes" You could add the existing title as a summary: "/summary Move SimpleSelector and CompoundSelector to internal packages" ------------- PR Comment: https://git.openjdk.org/jfx/pull/1333#issuecomment-2217830387
