On Fri, 26 Jul 2024 18:18:07 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix bug where String was being used as if it were a Project
>
> build.gradle line 1799:
>
>> 1797: if (!projectDependencies.empty) {
>> 1798: projectDependencies.each { dep ->
>> 1799: def depName =
>> dep.moduleName.replace('.', '-')
>
> I was doing one last check and noticed a bug here. As with the earlier block
> on line 1716, the `projectDependencies.each` line needs to be replaced with:
>
>
> projectDependencies.each { projName ->
> def dep = project.project(":$projName")
>
>
> since `dep` needs to be a gradle Project not a String.
>
> I'll test it and fix it.
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1518#discussion_r1693680147
