On Fri, 2 Aug 2024 06:36:22 GMT, Hima Bindu Meda <hm...@openjdk.org> wrote:
> Updated libxslt to v1.1.42. Verified build on all platforms. No issue seen Looks good, although I notice one difference between the upstream libxslt repo and this PR in a now-unmaintained config file: diff -u -w -r $JFX/modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt.m4 $LIBXML/libxslt.m4 --- $JFX/modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt.m4 2023-07-27 15:08:29.124274800 -0700 +++ $LIBXML/libxslt.m4 2024-08-02 10:18:29.007649600 -0700 @@ -5,6 +5,8 @@ # Configure paths for GLIB # Owen Taylor 97-11-3 # +# Deprecated and unmaintained. Use pkg-config or xslt-config. +# # Modified to work with libxslt by Thomas Schraitle 2002/10/25 # Fixed by Edward Rudd 2004/05/12 Do we use `libxslt.m4` when we run configure to generate the platform-specific headers? If not, I recommend that you remove it from our repo. If we do, please add the two lines from the above patch so that we match the upstream. Note that the deprecation comment was added by: https://gitlab.gnome.org/GNOME/libxslt/-/commit/200ee26982b4c8cbe165555ae36aa684a744ccf4 so we will eventually need to stop using it if we still are. ------------- PR Review: https://git.openjdk.org/jfx/pull/1527#pullrequestreview-2216151444
