On Thu, 15 Aug 2024 17:49:15 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Well, you _do_ modify this file significantly, so it's not entirely out of >> scope. I've been converting files over to JUnit5 in the past as part of >> significant modifications, I think it's a valid path to get us to eventually >> move completely to JUnit5 (because as you say, bulk conversion isn't >> probably happening any time soon). > > I do that too, typically. But here I just copied some code from a sibling > test. > > If we are converting, then we also should convert MenuButtonTest as well, and > now we are widening the scope. There is no gain in going with junit5 with > this test specifically, so I don't really want to do it right now, I would > rather do it as a part of a bulk change. > > Do you want me to convert this test? created https://bugs.openjdk.org/browse/JDK-8338468 ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1535#discussion_r1718786150
