On Thu, 22 Aug 2024 16:09:29 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:

> Update copyright year in files updated in year 2024.
> This update is done specifically to update the year in webkit files, so that 
> the webkit source shows no diff.

Looks good except for two media files. One definitely must be reverted (the 
legal file) and the other probably should be.

modules/javafx.media/src/main/legal/libffi.md line 38:

> 36: Copyright (C) 2002-2007  Bo Thorsen <b...@suse.de>
> 37: Copyright (C) 2021  Microsoft, Inc.
> 38: Copyright (c) 2022, 2024, Oracle and/or its affiliates.

Please revert this (we should not update `.md` files in `/src/main/legal`).

modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/prep_cif.c 
line 4:

> 2:    prep_cif.c - Copyright (c) 2011, 2012, 2021  Anthony Green
> 3:                 Copyright (c) 1996, 1998, 2007  Red Hat, Inc.
> 4:                 Copyright (c) 2022, 2024, Oracle and/or its affiliates.

I'm not sure that we should modify this either. It seems best to revert it.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1543#pullrequestreview-2255182188
PR Review Comment: https://git.openjdk.org/jfx/pull/1543#discussion_r1727502994
PR Review Comment: https://git.openjdk.org/jfx/pull/1543#discussion_r1727518491

Reply via email to