On Thu, 29 Aug 2024 14:11:01 GMT, Oliver Schmidtmer <d...@openjdk.org> wrote:
>> FileSystemJava had no valid implementation for pathFileName since the >> function was renamed from pathGetFileName to pathFileName in the >> FileSystem.h from WebKit > > Oliver Schmidtmer has updated the pull request incrementally with one > additional commit since the last revision: > > add test The fix looks reasonable to me, but I'll let @arapte be the primary reviewer, so this isn't a formal review. I was testing #1547 anyway, so I created a test branch with both that fix and this one merged together and ran it through our CI system. I confirm that the newly added test for _this_ PR fails without the fix and passes with the fix. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1551#issuecomment-2319182764
