On Thu, 5 Sep 2024 20:29:17 GMT, Andy Goryachev <[email protected]> wrote:
>> I've added tests for a `null` argument, as well as for an unsupported type
>> for the `BORDER_IMAGE_SOURCE` and `BACKGROUND_IMAGE` mappings.
>>
>> As for your third bullet point, I think you mean `convert` and not
>> `convertBack`. You can only pass "wrong" things into the former, not the
>> latter method. While more tests for `convert` would be good, they shouldn't
>> be done as part of this PR since it is unrelated code.
>
> you are probably right. I was thinking of a rather contrived case like
>
>
> void wrong() {
> SubPropertyConverter c = (SubPropertyConverter)converter;
> c.convertBack(new Object());
> }
>
>
> my question about _documenting_ nullability still stands though.
I've added the appropriate javadoc documentation for that.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1522#discussion_r1746144798
