On Fri, 6 Sep 2024 16:56:43 GMT, Andy Goryachev <[email protected]> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove documentation
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 421:
>
>> 419: public abstract sealed class Node
>> 420: implements EventTarget, Styleable
>> 421: permits AbstractNode, Camera, LightBase, Parent, SubScene,
>> Canvas, ImageView, Shape, Shape3D {
>
> We may need to use stronger wording in javadoc in regards to extending Nodes.
> should -> must, etc. (or, rather, 'cannot' and possibly explain why?)
I've removed the language that you can't extend those classes, as it is now
redundant because it is enforced by the compiler. We shouldn't document obvious
facts without providing any added value (for example, adding context and
reasoning _why_ it's the way it is).
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1556#discussion_r1749339201
