On Mon, 23 Sep 2024 13:19:36 GMT, Lukasz Kostyra <lkost...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 24 additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/master' into 8339510.junit5.system >> - more fixes >> - rotate test >> - review comments >> - unused imports >> - fixes 4 >> - fixes 3 >> - fixes 2 >> - fixes 1 >> - part 12 last >> - ... and 14 more: https://git.openjdk.org/jfx/compare/206e184f...777620ef > > tests/system/src/test/java/test/javafx/scene/Snapshot1Test.java line 265: > >> 263: // Should not get here >> 264: latch.countDown(); >> 265: throw new AssertionError("Should never get here"); > > Should probably be `fail` won't compile with `fail()`, needs an exception > tests/system/src/test/java/test/javafx/scene/Snapshot1Test.java line 387: > >> 385: // Should not get here >> 386: latch.countDown(); >> 387: throw new AssertionError("Should never get here"); > > Should probably be `fail` won't compile with `fail()`, needs an exception ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1569#discussion_r1771973318 PR Review Comment: https://git.openjdk.org/jfx/pull/1569#discussion_r1771973375
