On Mon, 14 Oct 2024 23:58:46 GMT, Kevin Rushforth <[email protected]> wrote:
>> Lukasz Kostyra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review fixes
>>
>> - Change exception message in loadAll() to include original resource
>> path
>> - Add a test case to ImageStorageTest checking if we load a correct
>> resource when both <res> and <res>@1x are present
>
> modules/javafx.graphics/src/test/java/test/com/sun/javafx/iio/ImageStorageTest.java
> line 63:
>
>> 61:
>> 62: @Test
>> 63: public void testImageNameFallbackTo1X() throws ImageStorageException
>> {
>
> This will test that the fallback works if there is an `@1x` name without the
> base name being present. Good.
>
> Can you think of a good way to test that it will _only_ fall back if there is
> no image name without any `@Nx`? Other than creating a pair of images that
> are different (e.g., differently sized) and seeing if it loads the one you
> expect, I can't think of a good way. It might or might not be worth doing.
I created an extra test with this specific case
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1598#discussion_r1802911707
