On Sat, 19 Oct 2024 15:47:42 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:

>> I would think that this is acceptable, since that's the exception message 
>> that we expect to see (if the `@1x` version also can't be found).
>
> I think the call stack being different is fine; call stacks are there for 
> developers to debug code, and the users that are seeing these will not be 
> debugging that particular code so the callstack being slightly off at the 
> deepest level is fine.  Altenatively, you could still consider adding the 
> `@1x` exception as a supressed exception to the first one (with 
> Exception#addSuppressed`) but I wouldn't bother for this case.

All done, with fallback exception added as suppressed

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1598#discussion_r1808602072

Reply via email to