On Mon, 21 Oct 2024 18:38:23 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Removed "not yet fully implemented" USE_MULTIPLE_NODES and related code. >> >> I would like to remove the early unfinished idea of using multiple Text >> nodes in TextAreaSkin to clean up the code, to make it easier to do fixes >> for [JDK-8342233](https://bugs.openjdk.org/browse/JDK-8342233) and >> [JDK-8296266](https://bugs.openjdk.org/browse/JDK-8296266). >> >> Also some minor cleanup. >> >> ## Summary of Changes >> >> - removed USE_MULTIPLE_NODES and code paths that correspond to its `true` >> value >> - permanently adding one Text node to `paragraphNodes` Group, keeping the >> latter for compatibility purposes >> - removed any code that scans `paragraphNodes` children >> - using `getTextNode()` in place of >> `((Text)paragraphNodes.getChildren().get(0))` > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextAreaSkin.java > line 821: > >> 819: if (y < contentView.snappedTopInset()) { >> 820: // Select the character at x in the first row >> 821: return 0; > > I see that the implementation of the now-removed `getNextInsertionPoint` > method also returned `0` unconditionally, so this is equivalent, but... isn't > the comment wrong, since `x` isn't used in this case? comment is indeed wrong, will fix. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1601#discussion_r1809399646
