On Mon, 28 Oct 2024 19:02:05 GMT, Michael Strauß <[email protected]> wrote:
>> I think the javadoc for `Node.focusVisible` (and its sibling
>> `Node.focusWithin`) is rather insufficient. The JBS ticket is not a
>> normative document, perhaps this should be clarified in a follow-up ticket
>> (by moving some of the verbiage from JDK-8268225 ?)
>>
>> I am not against adding a boolean for `visible` (or `focusVisible` ?)
>> argument.
>>
>> @mstr2 what would be a good description for this parameter?
>
> What do you think of the following:
>
> * @param visible Specifies whether the {@link #focusVisibleProperty()
> focusVisible} flag will be
> * set on the node that receives focus. Callers must specify
> {@code true} if this
> * method is called as a result of keyboard navigation, or if
> the current node
> * visibly indicates focus; in all other cases, callers must
> specify {@code false}.
I like that, it clearly explains what to do. thank you!
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1604#discussion_r1819603294
