On Fri, 25 Oct 2024 17:32:40 GMT, Kevin Rushforth <[email protected]> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> break iterator
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/TextPos.java
> line 34:
>
>> 32: * For that, use {@link Marker}.
>> 33: */
>> 34: public final class TextPos implements Comparable<TextPos> {
>
> Remind me why this isn't a record? It seems like it could be, unless I'm
> missing something.
it could be.
does it absolutely have to be? the class is final, and we have greater
flexibility in naming the accessors than with a record, not that we use it here.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1821431094
