On Mon, 28 Oct 2024 15:01:47 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
> Removes doPrivileged in the following module:
>
> - javafx.controls
>
> See JDK-8342441 for details.
>
> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
> whitespace" option.
This looks good to me. I left a minor comment about the "TODO" you added
(doesn't seem related or needed). I'll reapprove if you decide to change it.
modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextInputControlSkin.java
line 149:
> 147:
> 148: private static boolean initPreload() {
> 149: // TODO only used when IS_FXVK_SUPPORTED is true, optimize?
This seems an unrelated TODO (and very unlikely to be worth doing anyway).
-------------
Marked as reviewed by kcr (Lead).
PR Review: https://git.openjdk.org/jfx/pull/1615#pullrequestreview-2399443191
PR Review Comment: https://git.openjdk.org/jfx/pull/1615#discussion_r1819279264
