On Thu, 31 Oct 2024 17:17:36 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/StyleManager.java
>> line 1063:
>>
>>> 1061: ** That way there in no information leaked.
>>> 1062: */
>>> 1063: catch (java.net.URISyntaxException e) {
>>
>> are you sure the change is equivalent?
>>
>> For example, the old code catches `URISyntaxException` and
>> `PrivilegedActionException` returning `null`, but the new code does not,
>> unless I am mistaken.
>
> See my previous comment. This entire block is dead code that cannot possibly
> be reached in the absence of a security manager.
yes, you are right. _all is super_.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1619#discussion_r1824909283
