On Thu, 31 Oct 2024 17:50:11 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Lukasz Kostyra has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Scene: Remove missed doPrivileged use > > modules/javafx.graphics/src/main/java/com/sun/javafx/font/PrismFontFile.java > line 248: > >> 246: e.printStackTrace(); >> 247: } >> 248: } finally { > > Same comment as above: I'm not sure the `finally` is needed (although it > seems not harmful, I don't think it is equivalent in the presence of a thrown > `Error`). Done ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1619#discussion_r1825621082