On Tue, 5 Nov 2024 01:06:25 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/WindowControlsOverlay.java
>> line 78:
>>
>>> 76: *
>>> 77: * <table style="white-space: nowrap">
>>> 78: * <caption>CSS properties of {@code
>>> window-button-container}</caption>
>>
>> The new CSS properties need to be included in `cssref.html`, along with the
>> description of platform availability.
>>
>> Should this be done as part of this PR? (that would be my preference)
>
> `WindowControlsOverlay` is not API, it's an implementation detail and as such
> must not be documented in `cssref.html`. This is by design: currently, this
> feature has a minimal API with just three new API elements:
> `StageStyle.EXTENDED`, `HeaderBar`, and `HeaderBarBase`. If we allowed app
> developers to customize window buttons, the API would explode in size and the
> specification burden would be immense. Let's not go there.
I am confused. Can it be customized with a style sheet? If so, it should be
documented, no?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1829607426
