On Tue, 5 Nov 2024 18:51:34 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Ambarish Rapte has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - review: rm unused acc >> - Merge branch 'master' into rm-doPrivi >> - rm doPrivileged in javafx.base > > modules/javafx.base/src/main/java/javafx/beans/property/adapter/JavaBeanBooleanProperty.java > line 42: > >> 40: import java.security.AccessControlContext; >> 41: import java.security.AccessController; >> 42: import java.security.PrivilegedAction; > > I think you can remove the now-unused field `private final > AccessControlContext acc`, which will also let you remove the > `AccessControlContext` and `AccessController`. Alternatively, I will remove > them as part of [JDK-8342993](https://bugs.openjdk.org/browse/JDK-8342993). > > This comment applies to all of the `JavaBeanXXXProperty` classes. Thanks Kevin, The variable `acc` and related 2 imports are now removed in [commit](https://github.com/openjdk/jfx/pull/1625/commits/70ebdf944e6b31b731dc2be93ddda78e0402d700). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1625#discussion_r1830349887
