> Replaces the manual versions handling with 
> [Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html).
> 
> Changes:
> * Removed the methods `parseJavaVersion(String)`, `parseJdkVersion(String)` 
> and `compareJdkVersion(String, String)`, and replaced them with 
> `Version.parse` and `Version.compareTo` methods.
> * Removed the build properties of the Java version on which the Gradle build 
> runs because they are only used for logging. Replaced with logging them 
> directly. Note that Gradle logs by itself the info of the runtime it uses, so 
> there's no need to logs these manually.
> * Simplified the build JDK version by working directly with `Version` instead 
> of a `String`. This allows to store less build properties. Also used 
> try-with-resources to close the stream. Note that the whole build JDK manual 
> invocation hack should be replaced with the Java Toolchain.
> * Simplified the `verifyJava` task, which could also be replaced with 
> built-in Gradle tools.

Nir Lisker has updated the pull request incrementally with one additional 
commit since the last revision:

  Add missing :

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1647/files
  - new: https://git.openjdk.org/jfx/pull/1647/files/a633abb3..3337f6c5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1647&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1647&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jfx/pull/1647.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1647/head:pull/1647

PR: https://git.openjdk.org/jfx/pull/1647

Reply via email to