On Tue, 26 Nov 2024 08:59:10 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> This PR changes all `RT-XXXX` references to `JDK-XXXXXXX`. >> It also removes all `http://javafx-jira.kenai.com/browse/` occurrences. >> >> As discussed, this will help a lot when looking up old issues, especially >> since not everybody know how to do a lookup with the `RT-XXXX` number in the >> JIRA. >> >> Thanks to @kevinrushforth who provided the mapping! >> I wrote a small Java program that replaces all the occurrences. This >> includes the following files: >> - `.java, .css, .m, .h, .cc, .vert, .jsl, .c, .cpp` > > Marius Hanl has updated the pull request incrementally with one additional > commit since the last revision: > > 8344899: Remove occurrences of old JIRA tickets > > Including: > - JFXC > - DTL > - JMY Looks good except for a few changes in `StylesheetTest.java` where the `RT-nnnnn` refers to a filename and thus should be reverted. modules/javafx.graphics/src/test/java/test/javafx/css/StylesheetTest.java line 468: > 466: > 467: try { > 468: // Make sure JDK-8123343.css can be parsed, serialized and > deserialized with the current code, This refers to the name of a file, so should be reverted. modules/javafx.graphics/src/test/java/test/javafx/css/StylesheetTest.java line 487: > 485: > 486: @Test public void testRT_30953_deserialize_from_v4() { > 487: // JDK-8123343-v4.bss was generated with version 4 Should be reverted. modules/javafx.graphics/src/test/java/test/javafx/css/StylesheetTest.java line 495: > 493: public void testRT_30953_deserialize_from_2_2_45() { > 494: > 495: // JDK-8123343-2.2.4bss was generated with javafx version 2.2.45 > from 7u?? Should be reverted. modules/javafx.graphics/src/test/java/test/javafx/css/StylesheetTest.java line 503: > 501: public void testRT_30953_deserialize_from_2_2_4() { > 502: > 503: // JDK-8123343-2.2.4bss was generated with javafx version 2.2.4 > from 7u10 Should be reverted. modules/javafx.graphics/src/test/java/test/javafx/css/StylesheetTest.java line 511: > 509: public void testRT_30953_deserialize_from_2_2_21() { > 510: > 511: // JDK-8123343-2.2.21.bss was generated with javafx version > 2.2.21 from 7u21 Should be reverted. ------------- PR Review: https://git.openjdk.org/jfx/pull/1648#pullrequestreview-2465249299 PR Review Comment: https://git.openjdk.org/jfx/pull/1648#discussion_r1860800966 PR Review Comment: https://git.openjdk.org/jfx/pull/1648#discussion_r1860801569 PR Review Comment: https://git.openjdk.org/jfx/pull/1648#discussion_r1860801776 PR Review Comment: https://git.openjdk.org/jfx/pull/1648#discussion_r1860801975 PR Review Comment: https://git.openjdk.org/jfx/pull/1648#discussion_r1860802227
