On Mon, 2 Dec 2024 19:18:18 GMT, Andy Goryachev <[email protected]> wrote:
>> A small refactoring of the Dimension classes.
>>
>> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
>> `com.sun.javafx.geom.Dimension2D`.
>> * `com.sun.javafx.geom.Dimension2D` became a record.
>> * `javafx.geometry.Dimension2D`: fields became `final`.
>>
>> I'm not sure we need the implementation class at all considering we are free
>> to use the public one.
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/geom/Dimension2D.java
> line 31:
>
>> 29: * A 2D dimension object that contains a width and a height.
>> 30: */
>> 31: public record Dimension2D(float width, float height) {}
>
> I wish this class was named differently to signify it's based on float...
Most of the classes in this package are based on floats. As this is an internal
class, adding a comment seems sufficient.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1653#discussion_r1866515370
