On Wed, 4 Dec 2024 19:39:33 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Move it to a Robot test >> - Fix test to fail without the fix > > tests/system/src/test/java/test/robot/javafx/stage/StageMixedSizeTest.java > line 61: > >> 59: final int finalWidth = 200; >> 60: >> 61: setupContentSizeTestStage(300, 300, > > Minor: consider using a final variable for the initial size Done. > tests/system/src/test/java/test/robot/javafx/stage/StageMixedSizeTest.java > line 67: > >> 65: assertTrue(latch.await(TIMEOUT, TimeUnit.MILLISECONDS), "Timeout >> waiting for test stage to be shown"); >> 66: >> 67: runAndWait(() -> assertColorDoesNotEqual(BACKGROUND_COLOR, >> getColor(290, 100), TOLERANCE)); > > Minor: consider deriving the x pos as initial size - 10 Done. > tests/system/src/test/java/test/robot/javafx/stage/StageMixedSizeTest.java > line 102: > >> 100: } >> 101: >> 102: > > Minor: extra blank line can be removed Done. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1654#discussion_r1870280844 PR Review Comment: https://git.openjdk.org/jfx/pull/1654#discussion_r1870280681 PR Review Comment: https://git.openjdk.org/jfx/pull/1654#discussion_r1870280481
