On Fri, 6 Dec 2024 17:47:07 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> This PR removes obsolete permission checks from javafx.graphics _minus_ Font
>> classes (handled by a separate PR).
>>
>> The only part I did not remove from methods/fields listed in the issue is
>> `WindowStage.fullScreenFromUserEvent`. This flag seems quite extensively
>> used and did not seem to have anything to do with permission checks.
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java
> line 597:
>
>> 595: // event handler.
>> 596: // If not notify the stageListener to reset fullscreen
>> to false.
>> 597: if (!fullScreenFromUserEvent) {
>
> is this correct?
>
> do I understand that the effective value for isTrusted is true, which makes
> the condition that the if tests false, so the (new) lines 598-599 would never
> execute.
Good catch. You are right. The entire block should be removed. As it is, this
will incorrectly limit the set of keys that can be accessed in full-screen mode.
This might be why Lukasz thought that `fullScreenFromUserEvent` was still
needed.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1658#discussion_r1873793681
