On Thu, 5 Dec 2024 07:12:20 GMT, Helly Guo <d...@openjdk.org> wrote: >> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 114 commits: >> >> - Merge branch 'master' into new_ime >> - Set IBUS_ENABLE_SYNC_MODE=1 >> - Revert "Set IBUS_ENABLE_SYNC_MODE=1" >> >> This reverts commit 8eccd9866b1e9931356557463997ccf53673fbfa. >> - Set IBUS_ENABLE_SYNC_MODE=1 >> - Merge branch 'master' into new_ime >> - Merge branch 'master' into new_ime >> - Revert "Fix for Polish AltGR combinations" >> >> This reverts commit 78e27e9deba2eda96b86186692da4f8dc2a3a1ff. >> - Revert "Fix the case when IME filters key_press (Polish ALT Gr + C)" >> >> This reverts commit 112ed6f4306a42378255c858306f9625ea2b5fa8. >> - Revert "Remove idea file" >> >> This reverts commit e56588baad42c07a5b872d27603a97e06be97649. >> - Remove idea file >> - ... and 104 more: https://git.openjdk.org/jfx/compare/67eed6d8...16b3eebe > > modules/javafx.graphics/src/main/native-glass/gtk/glass_window_ime.cpp line > 100: > >> 98: >> 99: void WindowContextBase::commitIME(gchar *str) { >> 100: if (im_ctx.on_preedit) { > > Through `LOG0`/`LOG1`, I found that the value of `im_ctx.on_preedit` is > `false` under `fcitx`. > I removed this check, then tested under `fcitx` and `ibus`. All passed.
@hellyguo Could you provide more details on which Linux distribution, input method, and fcitx version you're using? I just tested this on Ubuntu 24.10. For Chinese I'm using Intelligent Pinyin and for Japanese I'm using Mozc. Everything worked under Ibus but when I switched to fcitx 4 both my Chinese and Japanese input methods stopped working for all apps, not just JavaFX. This makes me think that I'm not setting up fcitx correctly. I did reboot at each step as I changed the configuration. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1080#discussion_r1876389777
